drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4280) Kerberos Authentication
Date Tue, 07 Feb 2017 18:20:44 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856485#comment-15856485
] 

ASF GitHub Bot commented on DRILL-4280:
---------------------------------------

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r99881850
  
    --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp ---
    @@ -0,0 +1,210 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#include <vector>
    +#include <boost/algorithm/string.hpp>
    +#include <boost/assign.hpp>
    +#include "saslAuthenticatorImpl.hpp"
    +
    +#include "drillClientImpl.hpp"
    +#include "logger.hpp"
    +
    +namespace Drill {
    +
    +#define DEFAULT_SERVICE_NAME "drill"
    +
    +#define KERBEROS_SIMPLE_NAME "kerberos"
    +#define KERBEROS_SASL_NAME "gssapi"
    +#define PLAIN_NAME "plain"
    +
    +const std::map<std::string, std::string> SaslAuthenticatorImpl::MECHANISM_MAPPING
= boost::assign::map_list_of
    +    (KERBEROS_SIMPLE_NAME, KERBEROS_SASL_NAME)
    +    (PLAIN_NAME, PLAIN_NAME)
    +;
    +
    +boost::mutex SaslAuthenticatorImpl::s_mutex;
    +bool SaslAuthenticatorImpl::s_initialized = false;
    +
    +SaslAuthenticatorImpl::SaslAuthenticatorImpl(const DrillUserProperties* const properties)
:
    +    m_properties(properties), m_pConnection(NULL), m_secret(NULL) {
    +
    +    if (!s_initialized) {
    --- End diff --
    
    shouldn't this be in a static member? we already have a place where the driver does a
bunch of static initialization anyway...
    
    Then the object could just check if the library was successfully initialized, and if not,
any attempt at initialization would fail.


> Kerberos Authentication
> -----------------------
>
>                 Key: DRILL-4280
>                 URL: https://issues.apache.org/jira/browse/DRILL-4280
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Keys Botzum
>            Assignee: Sudheesh Katkam
>              Labels: security
>
> Drill should support Kerberos based authentication from clients. This means that both
the ODBC and JDBC drivers as well as the web/REST interfaces should support inbound Kerberos.
For Web this would most likely be SPNEGO while for ODBC and JDBC this will be more generic
Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a lot of reuse
of ideas if not implementation.
> Note that this is related to but not the same as https://issues.apache.org/jira/browse/DRILL-3584




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message