drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2116) Add non-reserved keywords to non-reserved keyword list in parser
Date Wed, 22 Feb 2017 23:33:44 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879468#comment-15879468
] 

ASF GitHub Bot commented on DRILL-2116:
---------------------------------------

Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r102602855
  
    --- Diff: exec/java-exec/src/main/codegen/data/Parser.tdd ---
    @@ -39,7 +39,13 @@
         "METADATA",
         "DATABASE",
         "IF",
    -    "JAR"
    +    "JAR",
    +    "ANALYZE",
    +    "COMPUTE",
    +    "ESTIMATE",
    +    "STATISTICS",
    +    "SAMPLE",
    +    "PERCENT"
    --- End diff --
    
    @sudheeshkatkam mentioned
    > Something like this came up before where a list of non reserved keyword might result
in some ambiguous queries. See DRILL-2116. Also DRILL-3875.
    
    Hence, these keywords were not added to the non-reserved keyword list. Also, I am not
sure how we can preserve backward compatibility here.


> Add non-reserved keywords to non-reserved keyword list in parser
> ----------------------------------------------------------------
>
>                 Key: DRILL-2116
>                 URL: https://issues.apache.org/jira/browse/DRILL-2116
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: SQL Parser
>            Reporter: Jacques Nadeau
>             Fix For: Future
>
>
> There are a number of keywords in Drill that shouldn't be considered reserved when parsing.
 Calcite allows us to customize the list of un-reserved keywords and we should update the
list to allow more words.  Things that I've run across include value, user, left, etc.  
> This is a very common usability problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message