Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 80B5C200C04 for ; Tue, 24 Jan 2017 22:20:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7F285160B3E; Tue, 24 Jan 2017 21:20:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C7CAF160B38 for ; Tue, 24 Jan 2017 22:20:00 +0100 (CET) Received: (qmail 89471 invoked by uid 500); 24 Jan 2017 21:20:00 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 89462 invoked by uid 99); 24 Jan 2017 21:20:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jan 2017 21:20:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8DBDE180667 for ; Tue, 24 Jan 2017 21:19:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.998 X-Spam-Level: X-Spam-Status: No, score=-1.998 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 7msC5DCFUFd1 for ; Tue, 24 Jan 2017 21:19:58 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 56FF85F3BF for ; Tue, 24 Jan 2017 21:19:58 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C4054E0146 for ; Tue, 24 Jan 2017 21:19:26 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 77BAA25288 for ; Tue, 24 Jan 2017 21:19:26 +0000 (UTC) Date: Tue, 24 Jan 2017 21:19:26 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-5218) Support Disabling Heartbeats in C++ Client MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 24 Jan 2017 21:20:01 -0000 [ https://issues.apache.org/jira/browse/DRILL-5218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836647#comment-15836647 ] ASF GitHub Bot commented on DRILL-5218: --------------------------------------- GitHub user sudheeshkatkam opened a pull request: https://github.com/apache/drill/pull/726 DRILL-5218: Support disabling hearbeats from C++ client + remove invalid code (server should not request "handshake" type), in fact, client should fail in that case You can merge this pull request into a Git repository by running: $ git pull https://github.com/sudheeshkatkam/drill DRILL-5218 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/726.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #726 ---- commit 6bc07bbba246ae376b6accc4e38f076bb15b83aa Author: Sudheesh Katkam Date: 2017-01-24T21:10:31Z DRILL-5218: Support disabling hearbeats from C++ client ---- > Support Disabling Heartbeats in C++ Client > ------------------------------------------ > > Key: DRILL-5218 > URL: https://issues.apache.org/jira/browse/DRILL-5218 > Project: Apache Drill > Issue Type: Bug > Components: Client - C++ > Reporter: Sudheesh Katkam > Assignee: Sudheesh Katkam > > Heartbeats between bits allow for detecting health of remotes, but heartbeats between client and bit may not be necessary? So allow to (at least) disable heartbeats between C++ client and bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)