drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurent Goujon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5219) Remove DrillUserProperties filtering in C++ driver
Date Wed, 25 Jan 2017 18:59:27 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838371#comment-15838371
] 

Laurent Goujon commented on DRILL-5219:
---------------------------------------

I used the wrong jira id in my commit description

{quote}
GitHub user laurentgo opened a pull request:

https://github.com/apache/drill/pull/727

DRILL-5119: Relax user properties validation in C++ client

Unlike Java client, C++ client only allows user properties present in a
whitelist. Relax this restriction so that user can add extra properties.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/laurentgo/drill laurent/DRILL-5219

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/727.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #727

commit 6cae1ae18c3fd876ba98130971216dbf5cb10324
Author: Laurent Goujon <laurent@dremio.com>
Date: 2017-01-25T18:32:33Z

DRILL-5119: Relax user properties validation in C++ client

Unlike Java client, C++ client only allows user properties present in a
whitelist. Relax this restriction so that user can add extra properties.
{quote}

> Remove DrillUserProperties filtering in C++ driver
> --------------------------------------------------
>
>                 Key: DRILL-5219
>                 URL: https://issues.apache.org/jira/browse/DRILL-5219
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - C++
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>            Priority: Minor
>
> Unlike the Java client, the C++ connector filter out unknown Drill user properties:
> https://github.com/apache/drill/blob/master/contrib/native/client/src/clientlib/drillClientImpl.cpp#L374
> This prevents a client (like the ODBC driver) to pass extra properties to the server
(like extra metainformation, or some specific behavior for a given software)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message