drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5172) Display elapsed time for queries in the UI
Date Tue, 10 Jan 2017 17:12:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815539#comment-15815539
] 

ASF GitHub Bot commented on DRILL-5172:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/719#discussion_r95411447
  
    --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
    @@ -13595,6 +13597,17 @@ public long getEnd() {
           return end_;
         }
     
    +    public String getDuration() {
    --- End diff --
    
    Actually, the right place to do this work is in the Java code that creates the "model"
that we pass to Freemarker. (Yeah, it is kind of complicated.)
    
    Freemarker uses the classic MVC model. The template is the view. Java builds the model.
(Let's ignore the controller for now.)
    
    For an example, look in `ProfileResources.java`, which is in this PR. Look at the `ProfileInfo`
class. Here we gather up the bits of information we want to display on the web page. Any calcs
needed to prepare the data are done here. Then, Freemarker simply pulls out the pre-created
data using the getter methods.
    
    So, the `ProfileInfo` class could be extended to have, say, the raw duration in ms along
with methods to return the computed values: `getDisplayDuration()` and `getDurationUnits()`.


> Display elapsed time for queries in the UI
> ------------------------------------------
>
>                 Key: DRILL-5172
>                 URL: https://issues.apache.org/jira/browse/DRILL-5172
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.9.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Minor
>             Fix For: 1.10.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the Web UI does not display the runtime for a query either in the list of
queries or the query profile page itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message