drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5097) Using store.parquet.reader.int96_as_timestamp gives IOOB whereas convert_from works
Date Mon, 16 Jan 2017 13:10:26 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823940#comment-15823940
] 

ASF GitHub Bot commented on DRILL-5097:
---------------------------------------

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/697#discussion_r96213729
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java
---
    @@ -132,6 +137,9 @@ protected void readField(long recordsToReadInThisPass) {
               valueVec.getMutator().setSafe(valuesReadInCurrentPass + i, getDateTimeValueFromBinary(binaryTimeStampValue));
             }
           }
    +      // The nanos precision is cut to millis. Therefore the length of single timestamp
value is 8 bytes(s)
    +      // instead of 12 byte(s).
    +      dataTypeLengthInBits = timestampLengthInBits;
    --- End diff --
    
    Yes, it is. Because when [`PARQUET_READER_INT96_AS_TIMESTAMP` is set to false](
    https://github.com/apache/drill/blob/83513daf0903e0d94fcaad7b1ae4e8ad6272b494/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java#L246)

    `NullableFixedBinaryAsTimeStampReader` will not used. Instead of that `NullableFixedBinaryReader`
will used.
    



> Using store.parquet.reader.int96_as_timestamp gives IOOB whereas convert_from works
> -----------------------------------------------------------------------------------
>
>                 Key: DRILL-5097
>                 URL: https://issues.apache.org/jira/browse/DRILL-5097
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Data Types, Storage - Parquet
>    Affects Versions: 1.9.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>             Fix For: Future
>
>         Attachments: data.snappy.parquet
>
>
> Using store.parquet.reader.int96_as_timestamp gives IOOB whereas convert_from works.

> The below query succeeds:
> {code}
> select c, convert_from(d, 'TIMESTAMP_IMPALA') from dfs.`/drill/testdata/parquet_timestamp/spark_generated/d3`;
> {code}
> The below query fails:
> {code}
> 0: jdbc:drill:zk=10.10.100.190:5181> alter session set `store.parquet.reader.int96_as_timestamp`
= true;
> +-------+---------------------------------------------------+
> |  ok   |                      summary                      |
> +-------+---------------------------------------------------+
> | true  | store.parquet.reader.int96_as_timestamp updated.  |
> +-------+---------------------------------------------------+
> 1 row selected (0.231 seconds)
> 0: jdbc:drill:zk=10.10.100.190:5181> select c, d from dfs.`/drill/testdata/parquet_timestamp/spark_generated/d3`;
> Error: SYSTEM ERROR: IndexOutOfBoundsException: readerIndex: 0, writerIndex: 131076 (expected:
0 <= readerIndex <= writerIndex <= capacity(131072))
> Fragment 0:0
> [Error Id: bd94f477-7c01-420f-8920-06263212177b on qa-node190.qa.lab:31010] (state=,code=0)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message