drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4956) Temporary tables support
Date Thu, 05 Jan 2017 02:34:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800057#comment-15800057
] 

ASF GitHub Bot commented on DRILL-4956:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r94638152
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java
---
    @@ -174,13 +174,23 @@ protected void setupNewSchema() throws IOException {
         schema = container.getSchema();
       }
     
    +  /** Clean up needs to be performed before closing writer. Partially written data will
be removed. */
       private void closeWriter() {
         if (recordWriter != null) {
           try {
             recordWriter.cleanup();
    -        recordWriter = null;
           } catch(IOException ex) {
             context.fail(ex);
    +      } finally {
    +        try {
    +          if (!processed) {
    +            recordWriter.abort();
    +          }
    +        } catch (IOException e) {
    +          logger.error("Abort failed. There could be leftover output files.");
    --- End diff --
    
    Maybe include exception in the logged message?


> Temporary tables support
> ------------------------
>
>                 Key: DRILL-4956
>                 URL: https://issues.apache.org/jira/browse/DRILL-4956
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>              Labels: doc-impacting
>             Fix For: Future
>
>
> Link to design doc - https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message