Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CC267200BDB for ; Mon, 12 Dec 2016 18:29:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CAD51160B22; Mon, 12 Dec 2016 17:29:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1E6BB160B1A for ; Mon, 12 Dec 2016 18:28:59 +0100 (CET) Received: (qmail 39608 invoked by uid 500); 12 Dec 2016 17:28:59 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 39597 invoked by uid 99); 12 Dec 2016 17:28:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2016 17:28:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3B0552C0057 for ; Mon, 12 Dec 2016 17:28:59 +0000 (UTC) Date: Mon, 12 Dec 2016 17:28:59 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-5123) Write query profile after sending final response to client to improve latency MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 12 Dec 2016 17:29:01 -0000 [ https://issues.apache.org/jira/browse/DRILL-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742525#comment-15742525 ] ASF GitHub Bot commented on DRILL-5123: --------------------------------------- GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/692 DRILL-5123: Write query profile after sending final response to client Write query profile after sending final response to client to improve latency In testing a particular query, I used a test setup that does not write to the "persistent store", causing query profiles to not be saved. I then changed the config to save them (to local disk). This produced about a 200ms difference in query run time as perceived by the client. I then moved writing the query profile after sending the client the final message. This resulted in an approximately 100ms savings, as perceived by the client, in query run time on short (~3 sec.) queries. You can merge this pull request into a Git repository by running: $ git pull https://github.com/paul-rogers/drill DRILL-5123 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/692.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #692 ---- commit eb3f0f675689b3e867e001b6718d068913491c31 Author: Paul Rogers Date: 2016-12-12T17:18:38Z DRILL-5123: Write query profile after sending final response to client to improve latency In testing a particular query, I used a test setup that does not write to the "persistent store", causing query profiles to not be saved. I then changed the config to save them (to local disk). This produced about a 200ms difference in query run time as perceived by the client. I then moved writing the query profile after sending the client the final message. This resulted in an approximately 100ms savings, as perceived by the client, in query run time on short (~3 sec.) queries. ---- > Write query profile after sending final response to client to improve latency > ----------------------------------------------------------------------------- > > Key: DRILL-5123 > URL: https://issues.apache.org/jira/browse/DRILL-5123 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.8.0 > Reporter: Paul Rogers > Assignee: Paul Rogers > Priority: Minor > > In testing a particular query, I used a test setup that does not write to the "persistent store", causing query profiles to not be saved. I then changed the config to save them (to local disk). This produced about a 200ms difference in query run time as perceived by the client. > I then moved writing the query profile _after_ sending the client the final message. This resulted in an approximately 100ms savings, as perceived by the client, in query run time on short (~3 sec.) queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)