Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Fri, 2 Dec 2016 18:02:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13024472.1480518193000.425731.1480701720053@Atlassian.JIRA>
In-Reply-To: <JIRA.13024472.1480518193000@Atlassian.JIRA>
References: <JIRA.13024472.1480518193000@Atlassian.JIRA> <JIRA.13024472.1480518193540@arcas>
Subject: [jira] [Commented] (DRILL-5085) Add / update description for
 dynamic UDFs directories in drill-env.sh and drill-module.conf
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 02 Dec 2016 18:02:01 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715825#comment-15715825 ] 

ASF GitHub Bot commented on DRILL-5085:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/672#discussion_r90689224
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -45,11 +45,13 @@ drill.client: {
       supports-complex-types: true
     }
     
    -// Directory is used as base for temporary storage of Dynamic UDF jars.
    -// Set this property if you want to have custom temporary directory, instead of generated at runtime.
    -// By default ${DRILL_TMP_DIR} is used if set.
    -// drill.tmp-dir: "/tmp"
    -// drill.tmp-dir: ${?DRILL_TMP_DIR}
    +// Location Drill uses for temporary files, such as downloaded dynamic UDFs jars.
    --- End diff --
    
    Can we leave it that, if blank, it will use the system-generated directory as you have in 1.9? This means we'll still need your getTmpDir method. To do the check for blank.
    
    Also, as it turns out, we already have a temp dir setting used elsewhere. Look in drill-override-example.conf under drill.sys.store.provider.local.path. It uses "/tmp/drill". Then it adds subdirs for storage plugins and what-not.
    
    Can we use "/tmp/drill/udf" as the base temp storage location for udfs to be consistent? Then we'd add the cluster-id, etc. as in your "cluster-temp-dir" below.
    
    And, yes, we have lots of places where we specify the temp file system (UDFs, the one cited above, the (unused) cache.hazel, the temp dirs for spilling, ...). We do need to create a project (later) to rationalize all of this...


> Add / update description for dynamic UDFs directories in drill-env.sh and drill-module.conf
> -------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5085
>                 URL: https://issues.apache.org/jira/browse/DRILL-5085
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.9.0
>            Reporter: Arina Ielchiieva
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.10.0
>
>
> 1. Add description for $DRILL_TMP_DIR in drill-env.sh
> 2. Update description for dynamic UDFs directories in drill-module.conf


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)