drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Rogers (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-5171) TestSort unit test tests the external sort, not the in-memory SortBatch
Date Thu, 29 Dec 2016 22:13:58 GMT
Paul Rogers created DRILL-5171:
----------------------------------

             Summary: TestSort unit test tests the external sort, not the in-memory SortBatch
                 Key: DRILL-5171
                 URL: https://issues.apache.org/jira/browse/DRILL-5171
             Project: Apache Drill
          Issue Type: Bug
    Affects Versions: 1.8.0
            Reporter: Paul Rogers


Drill provides two sort operators: an in-memory {{SortBatch}} and a spillable {{ExternalSortBatch}}.
The external sort is adaptive: it sorts in memory when it can, and spills when necessary.
Perhaps for this reason, the in-memory sort appears to be deprecated (but is not marked as
such.)

The in-memory sort has associated test case: {{TestSort}} and {{TestSimpleSort}}. When run,
{{TestSort}} actually uses the external sort. {{TestSimpleSort}} has a single test case which
is disabled.

The result is that no tests exist for the in-memory sort. That operator should be marked as
deprecated, or the test cases adjusted to actually exercise the in-memory sort operator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message