drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Rogers (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DRILL-5116) Enable generated code debugging in each Drill operator
Date Thu, 29 Dec 2016 22:15:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786217#comment-15786217
] 

Paul Rogers edited comment on DRILL-5116 at 12/29/16 10:15 PM:
---------------------------------------------------------------

To do this work we must execute unit tests for each operator. This required fixes to several
unit tests due to various problems.

Also, it turns out, several operators are special:

* {{StreamingAggBatch}} has no direct unit tests: DRILL-5168
* {{OrderedPartitionRecordBatch}} may not be used: it has a single unit test which has been
disabled until Drill provides a distributed cache.
* {{ProjectRecordBatch}} has unit tests that require Mockito, but those tests do not run under
Java 8 (DRILL-5170). Fortunately, other tests do exercise the project operator.
* {{SortBatch}} has no unit tests and may be deprecated. One test actually exercises the external
sort, the other is disabled (DRILL-5171). Code for this operator cannot be verified to work
with plain-old Java.



was (Author: paul-rogers):
To do this work we must execute unit tests for each operator. This required fixes to several
unit tests due to various problems.

Also, it turns out, several operators are special:

* {{StreamingAggBatch}} has no direct unit tests: DRILL-5168
* {{OrderedPartitionRecordBatch}} may not be used: it has a single unit test which has been
disabled until Drill provides a distributed cache.
* {{ProjectRecordBatch}} has unit tests that require Mockito, but those tests do not run under
Java 8 (DRILL-5170). Fortunately, other tests do exercise the project operator.


> Enable generated code debugging in each Drill operator
> ------------------------------------------------------
>
>                 Key: DRILL-5116
>                 URL: https://issues.apache.org/jira/browse/DRILL-5116
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.9.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>
> DRILL-5052 adds the ability to debug generated code. Some of the code generated by Drill's
operators has minor problems when compiled directly using the new technique. These issues
are ignore by the byte-code-merge technique uses in production. This ticket asks to try the
DRILL-5052 feature in each operator, clean up any minor problems, and ensure each operator
generates code suitable for debugging. Use the new {{CodeGenerator.plainOldJavaCapable()}}
method to mark each generated class as ready for "plain-old Java" code gen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message