drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5112) Unit tests derived from PopUnitTestBase fail in IDE due to config errors
Date Wed, 07 Dec 2016 05:30:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15727760#comment-15727760
] 

ASF GitHub Bot commented on DRILL-5112:
---------------------------------------

GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/681

    DRILL-5112: Unit tests derived from PopUnitTestBase fail in IDE due to config errors

    Tests rely on command-line settings in the pom.xml file. Those settings
    are not available when tests are run in Eclipse. Replicated required
    settings into the base test class (as in BaseTestQuery).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-5112

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #681
    
----
commit ddccb6a6ad16e49175bb90468a7845d9fae8eaac
Author: Paul Rogers <progers@maprtech.com>
Date:   2016-12-07T05:11:56Z

    DRILL-5112: Unit tests derived from PopUnitTestBase fail in IDE due to config errors
    
    Tests rely on command-line settings in the pom.xml file. Those settings
    are not available when tests are run in Eclipse. Replicated required
    settings into the base test class (as in BaseTestQuery).

----


> Unit tests derived from PopUnitTestBase fail in IDE due to config errors
> ------------------------------------------------------------------------
>
>                 Key: DRILL-5112
>                 URL: https://issues.apache.org/jira/browse/DRILL-5112
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>
> Drill provides a wide variety of unit tests. Many derive from {{PopUnitTestBase}} to
test the Physical OPerators.
> The tests use a default configuration:
> {code}
> protected static DrillConfig CONFIG;
>   @BeforeClass
>   public static void setup() {
>     CONFIG = DrillConfig.create();
>   }
> {code}
> The tests rely on config settings specified in the {{pom.xml}} file (see note below.)
When run in Eclipse, no such config exists, so the tests use only the default config. The
defaults allow a web server to be started.
> Many tests start multiple Drillbits using the above config. When this occurs, each tries
to start a web server. The second one fails because the HTTP port is already in use.
> The solution is to initialize the config using the same settings as used in the {{BaseTestQuery}}
test case: the unit tests then work fine in Eclipse.
> As an aside, having multiple ways to set up the Drill config (and other items) leads
to much wasted time as each engineer must learn the quirks of each test hierarchy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message