drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5085) Add / update description for dynamic UDFs directories in drill-env.sh and drill-module.conf
Date Tue, 06 Dec 2016 14:47:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725704#comment-15725704
] 

ASF GitHub Bot commented on DRILL-5085:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/672#discussion_r91085531
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -45,11 +45,13 @@ drill.client: {
       supports-complex-types: true
     }
     
    -// Directory is used as base for temporary storage of Dynamic UDF jars.
    -// Set this property if you want to have custom temporary directory, instead of generated
at runtime.
    -// By default ${DRILL_TMP_DIR} is used if set.
    -// drill.tmp-dir: "/tmp"
    -// drill.tmp-dir: ${?DRILL_TMP_DIR}
    +// Location Drill uses for temporary files, such as downloaded dynamic UDFs jars.
    --- End diff --
    
    1. Reverted generated directory logic.
    2. "/tmp/drill/udf" + cluster-id is not good idea, since local udf directory has similar
location as remote. And remote directory is generated as cluster-id + /udf. So I suggest to
keep it as is. Local registry is returned to use its previous composition logic.
    3. Removed "cluster-temp-dir", we don't need it for now.


> Add / update description for dynamic UDFs directories in drill-env.sh and drill-module.conf
> -------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5085
>                 URL: https://issues.apache.org/jira/browse/DRILL-5085
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.9.0
>            Reporter: Arina Ielchiieva
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.10.0
>
>
> 1. Add description for $DRILL_TMP_DIR in drill-env.sh
> 2. Update description for dynamic UDFs directories in drill-module.conf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message