drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4956) Temporary tables support
Date Mon, 19 Dec 2016 15:05:59 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761375#comment-15761375
] 

ASF GitHub Bot commented on DRILL-4956:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r91959700
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonRecordWriter.java
---
    @@ -82,6 +84,9 @@ public void init(Map<String, String> writerOptions) throws IOException
{
         Path fileName = new Path(location, prefix + "_" + index + "." + extension);
         try {
           stream = fs.create(fileName);
    +      // set storage strategy for folder and file
    +      storageStrategy.apply(fs, fileName.getParent());
    +      storageStrategy.apply(fs, fileName);
    --- End diff --
    
    1. Permissions will be updated. 
    For persistent: dir - 775, file - 644.
    For temporary: dir - 700, file - 600.
    2. We can't change the existing one, since writer is the one who creates the directory.
    3. `PARTITION BY` doesn't create sub-directories, it creates separate files for each partition.


> Temporary tables support
> ------------------------
>
>                 Key: DRILL-4956
>                 URL: https://issues.apache.org/jira/browse/DRILL-4956
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>              Labels: doc-impacting
>             Fix For: Future
>
>
> Link to design doc - https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message