drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4956) Temporary tables support
Date Tue, 06 Dec 2016 06:13:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724509#comment-15724509
] 

ASF GitHub Bot commented on DRILL-4956:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r91012086
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java
---
    @@ -30,15 +33,18 @@
     import org.apache.calcite.schema.SchemaPlus;
     import org.apache.calcite.tools.ValidationException;
     import org.apache.drill.exec.planner.sql.SchemaUtilites;
    +import org.apache.drill.exec.planner.sql.handlers.SqlHandlerUtil;
     import org.apache.drill.exec.proto.UserBitShared.UserCredentials;
     import org.apache.drill.exec.proto.UserProtos.Property;
     import org.apache.drill.exec.proto.UserProtos.UserProperties;
     import org.apache.drill.exec.server.options.OptionManager;
     import org.apache.drill.exec.server.options.SessionOptionManager;
     
     import com.google.common.collect.Maps;
    +import org.apache.drill.exec.store.AbstractSchema;
    +import org.apache.drill.exec.util.BiConsumer;
     
    -public class UserSession {
    +public class UserSession implements AutoCloseable {
    --- End diff --
    
    `AutoCloseable` is a funny thing... It is like `Closable`, but prefers to be used here:
    ```
    try( MyAutoCloseable foo = new MyAutoCloseable(..)) { }
    ```
    Since `UserSession` will never be used this way, plain old `Closable` may be fine.


> Temporary tables support
> ------------------------
>
>                 Key: DRILL-4956
>                 URL: https://issues.apache.org/jira/browse/DRILL-4956
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Arina Ielchiieva
>            Assignee: Paul Rogers
>              Labels: doc-impacting
>             Fix For: Future
>
>
> Link to design doc - https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message