drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4956) Temporary tables support
Date Tue, 06 Dec 2016 06:12:59 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724500#comment-15724500
] 

ASF GitHub Bot commented on DRILL-4956:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r90698347
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java
---
    @@ -235,4 +235,15 @@ public static void unparseSqlNodeList(SqlWriter writer, int leftPrec,
int rightP
         writer.keyword(")");
       }
     
    +  /**
    +   * Generates temporary table name using original table and unique identifies.
    +   *
    +   * @param tableName original table name
    +   * @param uuid unique identifier
    +   * @return generated temporary table name
    +   */
    +  public static String generateTemporaryTableName(String tableName, String uuid) {
    --- End diff --
    
    Generates a unique name. But, now the table name on disk will differ from the table name
that the user defined. Does the code handle this case: knows to look in a registry to translate
from one to the other? Would it be simpler to create a subdirectory with uuid, and put all
the tables for a session in that directory with their original name?


> Temporary tables support
> ------------------------
>
>                 Key: DRILL-4956
>                 URL: https://issues.apache.org/jira/browse/DRILL-4956
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Arina Ielchiieva
>            Assignee: Paul Rogers
>              Labels: doc-impacting
>             Fix For: Future
>
>
> Link to design doc - https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message