drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3510) Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL identifiers
Date Tue, 27 Dec 2016 15:08:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780573#comment-15780573
] 

ASF GitHub Bot commented on DRILL-3510:
---------------------------------------

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r93939395
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
---
    @@ -241,6 +244,10 @@ public long getInSubqueryThreshold() {
         return options.getOption(IN_SUBQUERY_THRESHOLD);
       }
     
    +  public boolean isAnsiQuotesEnabled() {
    --- End diff --
    
    For this reason maybe it makes sense to implement not boolean option ANSI_QUOTES, but
some string option, to turn on necessary lexical policy.  
    I raised this question in jira [DRILL-3510](https://issues.apache.org/jira/browse/DRILL-3510?focusedCommentId=15780561&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15780561)


> Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL identifiers

> --------------------------------------------------------------------------------------
>
>                 Key: DRILL-3510
>                 URL: https://issues.apache.org/jira/browse/DRILL-3510
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: SQL Parser
>            Reporter: Jinfeng Ni
>            Assignee: Vitalii Diravka
>             Fix For: Future
>
>         Attachments: DRILL-3510.patch, DRILL-3510.patch
>
>
> Currently Drill's SQL parser uses backtick as identifier quotes, the same as what MySQL
does. However, this is different from ANSI SQL specification, where double quote is used as
identifier quotes.  
> MySQL has an option "ANSI_QUOTES", which could be switched on/off by user. Drill should
follow the same way, so that Drill users do not have to rewrite their existing queries, if
their queries use double quotes. 
> {code}
> SET sql_mode='ANSI_QUOTES';
> {code}
>    



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message