drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitalii Diravka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3510) Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL identifiers
Date Tue, 27 Dec 2016 15:01:07 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780561#comment-15780561

Vitalii Diravka commented on DRILL-3510:

Adding ANSI_QUOTES option will allow to use [MYSQL_ANSI | https://github.com/apache/calcite/blob/0938c7b6d767e3242874d87a30d9112512d9243a/core/src/main/java/org/apache/calcite/config/Lex.java#L45]
lexical policy, since [CALCITE-803: Add a MYSQL_ANSI option for Lex options| https://issues.apache.org/jira/browse/CALCITE-803]
was resolved.

[~jni], [~jnadeau] Does it make sense to add not ANSI_QUOTES boolean option, but string option,
for example LEX_POLICY? It will allow to add the new lexical policies ([ORACLE, SQL_SERVER,
in the future.

> Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL identifiers

> --------------------------------------------------------------------------------------
>                 Key: DRILL-3510
>                 URL: https://issues.apache.org/jira/browse/DRILL-3510
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: SQL Parser
>            Reporter: Jinfeng Ni
>            Assignee: Vitalii Diravka
>             Fix For: Future
>         Attachments: DRILL-3510.patch, DRILL-3510.patch
> Currently Drill's SQL parser uses backtick as identifier quotes, the same as what MySQL
does. However, this is different from ANSI SQL specification, where double quote is used as
identifier quotes.  
> MySQL has an option "ANSI_QUOTES", which could be switched on/off by user. Drill should
follow the same way, so that Drill users do not have to rewrite their existing queries, if
their queries use double quotes. 
> {code}
> SET sql_mode='ANSI_QUOTES';
> {code}

This message was sent by Atlassian JIRA

View raw message