Return-Path: <issues-return-35617-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id BD0C0200BCB
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 24 Nov 2016 18:23:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id BBDCA160AFB; Thu, 24 Nov 2016 17:23:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0DBC5160B22
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 24 Nov 2016 18:22:59 +0100 (CET)
Received: (qmail 6976 invoked by uid 500); 24 Nov 2016 17:22:59 -0000
Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@drill.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@drill.apache.org>
List-Post: <mailto:issues@drill.apache.org>
List-Id: <issues.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list issues@drill.apache.org
Received: (qmail 6807 invoked by uid 99); 24 Nov 2016 17:22:59 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Nov 2016 17:22:59 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 9D4AC2C03F0
	for <issues@drill.apache.org>; Thu, 24 Nov 2016 17:22:58 +0000 (UTC)
Date: Thu, 24 Nov 2016 17:22:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12958616.1460582039000.362677.1480008178641@Atlassian.JIRA>
In-Reply-To: <JIRA.12958616.1460582039000@Atlassian.JIRA>
References: <JIRA.12958616.1460582039000@Atlassian.JIRA> <JIRA.12958616.1460582039766@arcas>
Subject: [jira] [Commented] (DRILL-4604) Generate warning on Web UI if
 drillbits version mismatch is detected
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 24 Nov 2016 17:23:00 -0000


    [ https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693829#comment-15693829 ] 

ASF GitHub Bot commented on DRILL-4604:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r89306930
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -17,17 +17,56 @@
       <a href="/queries">back</a><br/>
       <div class="page-header">
       </div>
    -  <div class="table-responsive">
    -    <table class="table table-hover">
    -      <tbody>
    -        <#list model as stat>
    -          <tr>
    -            <td style="border:none;"><b>${stat.getName()}</b></td>
    -            <td style="border:none; font-family: Courier;">${stat.getValue()}</td>
    -          </tr>
    -        </#list>
    -      </tbody>
    -    </table>
    +
    +  <#list model.getDrillbits() as drillbit>
    +    <#if !drillbit.isVersionMatch()>
    +      <div id="message" class="alert alert-danger alert-dismissable">
    --- End diff --
    
    Code was changes a little. But if we have drillbit version mismatch only one warning message will be displayed.  I'll add screenshots. Drillbits with mismatching version will have their version in red label, drillbits with matching version will have their version in green label.


> Generate warning on Web UI if drillbits version mismatch is detected
> --------------------------------------------------------------------
>
>                 Key: DRILL-4604
>                 URL: https://issues.apache.org/jira/browse/DRILL-4604
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>              Labels: doc-impacting
>             Fix For: Future
>
>         Attachments: index_page.JPG, index_page_mismatch.JPG, screenshots_with_different_states.docx
>
>
> Display drillbit version on web UI. If any of drillbits version doesn't match with current drillbit, generate warning.
> Screenshots - screenshots_with_different_states.docx.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)