Return-Path: <issues-return-34966-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B3858200BC4
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  4 Nov 2016 16:52:01 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id B2429160B0F; Fri,  4 Nov 2016 15:52:01 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 6D86C160B16
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  4 Nov 2016 16:52:00 +0100 (CET)
Received: (qmail 38987 invoked by uid 500); 4 Nov 2016 15:51:59 -0000
Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@drill.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@drill.apache.org>
List-Post: <mailto:issues@drill.apache.org>
List-Id: <issues.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list issues@drill.apache.org
Received: (qmail 38709 invoked by uid 99); 4 Nov 2016 15:51:59 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2016 15:51:59 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 569402C2A66
	for <issues@drill.apache.org>; Fri,  4 Nov 2016 15:51:59 +0000 (UTC)
Date: Fri, 4 Nov 2016 15:51:59 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12958616.1460582039000.190758.1478274719351@Atlassian.JIRA>
In-Reply-To: <JIRA.12958616.1460582039000@Atlassian.JIRA>
References: <JIRA.12958616.1460582039000@Atlassian.JIRA> <JIRA.12958616.1460582039766@arcas>
Subject: [jira] [Commented] (DRILL-4604) Generate warning on Web UI if
 drillbits version mismatch is detected
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 04 Nov 2016 15:52:01 -0000


    [ https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636774#comment-15636774 ] 

ASF GitHub Bot commented on DRILL-4604:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r86568133
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java ---
    @@ -55,44 +59,89 @@ public Viewable getStats() {
       @GET
       @Path("/stats.json")
       @Produces(MediaType.APPLICATION_JSON)
    -  public List<Stat> getStatsJSON() {
    -    List<Stat> stats = Lists.newLinkedList();
    -    stats.add(new Stat("Number of Drill Bits", work.getContext().getBits().size()));
    -    int number = 0;
    -    for (CoordinationProtos.DrillbitEndpoint bit : work.getContext().getBits()) {
    -      String initialized = bit.isInitialized() ? " initialized" : " not initialized";
    -      stats.add(new Stat("Bit #" + number, bit.getAddress() + initialized));
    -      ++number;
    +  public Stats getStatsJSON() {
    --- End diff --
    
    This message gets statistics, which is great. But, it seems to combine per-cluster stats with per-drillbit info. Perhaps either have two messages (one for cluster, the other for Drillbit) or use JSON structures:
    
    ```
    clusterStats: { drillbitCount: .., version: ... },
    drillbitStats: { userPort: ..., ... }
    ```


> Generate warning on Web UI if drillbits version mismatch is detected
> --------------------------------------------------------------------
>
>                 Key: DRILL-4604
>                 URL: https://issues.apache.org/jira/browse/DRILL-4604
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Sudheesh Katkam
>              Labels: doc-impacting
>             Fix For: Future
>
>         Attachments: index_page.JPG, index_page_mismatch.JPG, screenshots_with_different_states.docx
>
>
> Display drillbit version on web UI. If any of drillbits version doesn't match with current drillbit, generate warning.
> Screenshots - screenshots_with_different_states.docx.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)