drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5085) Add / update description for dynamic UDFs directories in drill-env.sh and drill-module.conf
Date Wed, 30 Nov 2016 16:22:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709014#comment-15709014
] 

ASF GitHub Bot commented on DRILL-5085:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/672#discussion_r90267374
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -207,11 +207,12 @@ drill.exec: {
           // Set this property if custom absolute root should be used for remote directories,
ex: root: "/app/drill".
           // root: "",
     
    -      // Relative base directory for all udf directories (local and remote).
    +      // Base directory for all udf directories (local and remote).
           base: ${drill.exec.zk.root}"/udf",
     
    -      // Relative path to local udf directory.
    -      // Generated temporary directory is used as root unless ${DRILL_TMP_DIR} or ${drill.tmp-dir}
is set.
    +      // Relative local udf directory. Drill temporary directory is used as root for
this directory.
    +      // Drill temporary directory is set to generated temporary directory
    +      // unless ${DRILL_TMP_DIR} or ${drill.tmp-dir} is set.
    --- End diff --
    
    Still not sure this entirely makes sense. This is a local file system directory. We describe
ow the default is based on DRILL_TMP_DIR, etc. That all make sense.
    
    But the actual default value is based on the base directory in the file system configured
by fs, which might be HDFS.
    
    And, since we specify a value here, the `drill.tmp.dir` will never be used.
    
    Do we really mean:
    ```
    local: "${drill-tmp-dir}/udfs"
    ```


> Add / update description for dynamic UDFs directories in drill-env.sh and drill-module.conf
> -------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5085
>                 URL: https://issues.apache.org/jira/browse/DRILL-5085
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.9.0
>            Reporter: Arina Ielchiieva
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.10.0
>
>
> 1. Add description for $DRILL_TMP_DIR in drill-env.sh
> 2. Update description for dynamic UDFs directories in drill-module.conf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message