drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5054) Provide jquery-ui and jquery-dataTables locally
Date Thu, 24 Nov 2016 00:17:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691747#comment-15691747
] 

ASF GitHub Bot commented on DRILL-5054:
---------------------------------------

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/663#discussion_r89419148
  
    --- Diff: exec/java-exec/src/main/resources/rest/query/result.ftl ---
    @@ -11,14 +11,13 @@
     
     <#include "*/generic.ftl">
     <#macro page_head>
    -  <link rel="stylesheet" type="text/css" href="//code.jquery.com/ui/1.10.3/themes/smoothness/jquery-ui.css">
    -  <link rel="stylesheet" type="text/css" href="//cdn.datatables.net/plug-ins/be7019ee387/integration/jqueryui/dataTables.jqueryui.css">
    +  <link rel="stylesheet" type="text/css" href="/static/css/jquery-ui.css">
    --- End diff --
    
    It's a good idea to have both CDN and local loading. Try CDN first and if that fails,
try the local set. Typically, the browser would have already got jquery and other common js
and css files cached and pages will therefore load faster. 
    See here: http://stackoverflow.com/questions/3832446/benefits-vs-pitfalls-of-hosting-jquery-locally
    and here: http://stackoverflow.com/questions/1014203/best-way-to-use-googles-hosted-jquery-but-fall-back-to-my-hosted-library-on-go
    
    Also, not too sure about including large js, png, and css files in the source tree. Should
we just put in code to try to load from a local location, and provide instructions to users
on how to download and set it up?
    
    If we do include the third party scripts, then I would also suggest coding the version
number into the name we keep locally: jquery-1.10.2.min.js instead of jquery.min.js, dataTables.colVis-1.1.0.min.js
instead of dataTables.colVis.min.js, etc.


> Provide jquery-ui and jquery-dataTables locally
> -----------------------------------------------
>
>                 Key: DRILL-5054
>                 URL: https://issues.apache.org/jira/browse/DRILL-5054
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.8.0
>         Environment: Fedora 24 / OpenJDK 8 / FireFox 50.0
>            Reporter: Hongze Zhang
>             Fix For: Future
>
>
> Hi,
> Currently Drill uses CDN for serving source files of jquery-ui and jquery-dataTables.
This is OK for most cases, but not working in an isolated environment.
> This is a patch adding these files so that Drill will work fine in intranet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message