drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4980) Upgrading of the approach of parquet date correctness status detection
Date Fri, 04 Nov 2016 02:22:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634976#comment-15634976

ASF GitHub Bot commented on DRILL-4980:

Github user vdiravka commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
    @@ -927,15 +927,11 @@ public void setMax(Object max) {
         @JsonProperty List<ParquetFileMetadata_v2> files;
         @JsonProperty List<String> directories;
         @JsonProperty String drillVersion;
    -    @JsonProperty boolean isDateCorrect;
    +    @JsonProperty int writerVersion;
    --- End diff --
    `ParquetTableMetadata_v2` is used mostly when the parquet meta cache file created. 
    For reading the metadata cache file or metadta footer this class is not used except the
case, when we read one parquet file or parquet folder, an empty instance of this class is
created, but used only columnTypeInfo field. And the drillVersion or writerVersion weren't
used. That's why everything worked but it was not right. I added an empty constructor (as
I made earlier, actually master version). 
    And added initializing this fields across constructors parameters. I think it is more
right and looks like this is what you were talking about.

> Upgrading of the approach of parquet date correctness status detection
> ----------------------------------------------------------------------
>                 Key: DRILL-4980
>                 URL: https://issues.apache.org/jira/browse/DRILL-4980
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Parquet
>    Affects Versions: 1.8.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>             Fix For: 1.9.0
> This jira is an addition for the [DRILL-4203|https://issues.apache.org/jira/browse/DRILL-4203].
> The date correctness label for the new generated parquet files should be upgraded. 

This message was sent by Atlassian JIRA

View raw message