drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4935) Allow drillbits to advertise a configurable host address to Zookeeper
Date Tue, 08 Nov 2016 19:23:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648533#comment-15648533
] 

ASF GitHub Bot commented on DRILL-4935:
---------------------------------------

Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/647
  
    Two ways to test.
    
    First, try the fix manually. Start Drill once without the env var set to ensure Drill
uses the default. Then, set the env var and ensure that Drill uses the correct value.
    
    Second, would be a unit test. I'm not familiar with any existing ZK unit tests. Do any
of the other committers know if we have such tests? Something that validates Drillbit registration,
etc? If so, then that test can be modified for this use case.
    
    But, there is one gotcha: in Java, env vars are read-only, there is no way to set env
vars in a test (that I've ever found.)  Anyone have a work-around?


> Allow drillbits to advertise a configurable host address to Zookeeper
> ---------------------------------------------------------------------
>
>                 Key: DRILL-4935
>                 URL: https://issues.apache.org/jira/browse/DRILL-4935
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Execution - RPC
>    Affects Versions: 1.8.0
>            Reporter: Harrison Mebane
>            Priority: Minor
>             Fix For: Future
>
>
> There are certain situations, such as running Drill in distributed Docker containers,
in which it is desirable to advertise a different hostname to Zookeeper than would be output
by INetAddress.getLocalHost().  I propose adding a configuration variable 'drill.exec.rpc.bit.advertised.host'
and passing this address to Zookeeper when the configuration variable is populated, otherwise
falling back to the present behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message