drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4935) Allow drillbits to advertise a configurable host address to Zookeeper
Date Tue, 08 Nov 2016 04:33:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646463#comment-15646463

ASF GitHub Bot commented on DRILL-4935:

Github user harrisonmebane commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -49,6 +49,7 @@
       String USER_RPC_TIMEOUT = "drill.exec.rpc.user.timeout";
       String METRICS_CONTEXT_NAME = "drill.exec.metrics.context";
       String USE_IP_ADDRESS = "drill.exec.rpc.use.ip";
    +  String BIT_ADVERTISED_HOST = "drill.exec.rpc.bit.advertised.host";
    --- End diff --
    That all seems reasonable to me.  I can't find any examples of environment variables being
accessed from in the Java code.  I assume we don't want the name of the environment variable
hard-coded in the hostname resolution code, but I'm not sure of the best place to define it,
    Thoughts?  I could put it in `ExecConstants` but it would be the only env variable in
there.  I could also just make it a static variable in the `ServiceEngine` class.
    Do we still want to provide the option to override through a system property, or just
rely on the environment variable?

> Allow drillbits to advertise a configurable host address to Zookeeper
> ---------------------------------------------------------------------
>                 Key: DRILL-4935
>                 URL: https://issues.apache.org/jira/browse/DRILL-4935
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Execution - RPC
>    Affects Versions: 1.8.0
>            Reporter: Harrison Mebane
>            Priority: Minor
>             Fix For: Future
> There are certain situations, such as running Drill in distributed Docker containers,
in which it is desirable to advertise a different hostname to Zookeeper than would be output
by INetAddress.getLocalHost().  I propose adding a configuration variable 'drill.exec.rpc.bit.advertised.host'
and passing this address to Zookeeper when the configuration variable is populated, otherwise
falling back to the present behavior.

This message was sent by Atlassian JIRA

View raw message