drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4935) Allow drillbits to advertise a configurable host address to Zookeeper
Date Mon, 07 Nov 2016 21:09:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645458#comment-15645458
] 

ASF GitHub Bot commented on DRILL-4935:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/647#discussion_r86868307
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -49,6 +49,7 @@
       String USER_RPC_TIMEOUT = "drill.exec.rpc.user.timeout";
       String METRICS_CONTEXT_NAME = "drill.exec.metrics.context";
       String USE_IP_ADDRESS = "drill.exec.rpc.use.ip";
    +  String BIT_ADVERTISED_HOST = "drill.exec.rpc.bit.advertised.host";
    --- End diff --
    
    Is this really what we want to do? After this change, each host will have its on Drill
config file. That means that, on every config change, the admin must:
    
    1. Modify a master file.
    2. Use a script to regenerate the per-host files.
    3. Push the per-host files to the remote systems.
    4. Restart the cluster.
    
    If Drill is deployed on a system such as YARN, it is not possible to have per-host config
files.


> Allow drillbits to advertise a configurable host address to Zookeeper
> ---------------------------------------------------------------------
>
>                 Key: DRILL-4935
>                 URL: https://issues.apache.org/jira/browse/DRILL-4935
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Execution - RPC
>    Affects Versions: 1.8.0
>            Reporter: Harrison Mebane
>            Priority: Minor
>             Fix For: Future
>
>
> There are certain situations, such as running Drill in distributed Docker containers,
in which it is desirable to advertise a different hostname to Zookeeper than would be output
by INetAddress.getLocalHost().  I propose adding a configuration variable 'drill.exec.rpc.bit.advertised.host'
and passing this address to Zookeeper when the configuration variable is populated, otherwise
falling back to the present behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message