drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4935) Allow drillbits to advertise a configurable host address to Zookeeper
Date Mon, 07 Nov 2016 07:03:59 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643331#comment-15643331
] 

ASF GitHub Bot commented on DRILL-4935:
---------------------------------------

Github user xhochy commented on a diff in the pull request:

    https://github.com/apache/drill/pull/647#discussion_r86720949
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
    @@ -142,7 +142,13 @@ private static BufferAllocator newAllocator(
     
       public DrillbitEndpoint start() throws DrillbitStartupException, UnknownHostException{
         int userPort = userServer.bind(config.getInt(ExecConstants.INITIAL_USER_PORT), allowPortHunting);
    -    String address = useIP ?  InetAddress.getLocalHost().getHostAddress() : InetAddress.getLocalHost().getCanonicalHostName();
    +    String configIP = config.getString(ExecConstants.BIT_ADVERTISED_HOST);
    +    String address = null;
    +    if (configIP == "") {
    --- End diff --
    
    You could use `config.hasPath` instead of relying on matching on an empty string.


> Allow drillbits to advertise a configurable host address to Zookeeper
> ---------------------------------------------------------------------
>
>                 Key: DRILL-4935
>                 URL: https://issues.apache.org/jira/browse/DRILL-4935
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Execution - RPC
>    Affects Versions: 1.8.0
>            Reporter: Harrison Mebane
>            Priority: Minor
>             Fix For: Future
>
>
> There are certain situations, such as running Drill in distributed Docker containers,
in which it is desirable to advertise a different hostname to Zookeeper than would be output
by INetAddress.getLocalHost().  I propose adding a configuration variable 'drill.exec.rpc.bit.advertised.host'
and passing this address to Zookeeper when the configuration variable is populated, otherwise
falling back to the present behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message