drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4604) Generate warning on Web UI if drillbits version mismatch is detected
Date Fri, 04 Nov 2016 16:16:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636864#comment-15636864
] 

ASF GitHub Bot commented on DRILL-4604:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r86579857
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -218,13 +218,18 @@ private void javaPropertiesToSystemOptions() {
       }
     
       /**
    -   * If cluster version is the same as default, update option to current drillbit version.
    +   * If cluster version is the same as default, updates option to current drillbit version.
    +   * Since getOption and setOption are separate calls, raise condition might occur
    +   * when several drillbits are registering at the same time.
    +   * It is assumed that the first drillbit in cluster sets cluster version
    +   * but when the raise condition occurs, it might be the second or the third etc.
    +   * This behaviour does not impose significant impact, since the main goal is to detect
mismatching versions.
        */
    -  private void checkAndUpdateClusterVersionOption(OptionManager optionManager, DrillbitEndpoint
drillbitEndpoint) {
    -    OptionValue versionOption = optionManager.getOption(ExecConstants.CLUSTER_VERSION);
    +  private void checkAndUpdateClusterVersionOption(OptionManager systemOptions, DrillbitEndpoint
drillbitEndpoint) {
    --- End diff --
    
    @paul-rogers 
    your alternative state-free solution totally makes sense. I'll make appropriate changes.
    Thank you!


> Generate warning on Web UI if drillbits version mismatch is detected
> --------------------------------------------------------------------
>
>                 Key: DRILL-4604
>                 URL: https://issues.apache.org/jira/browse/DRILL-4604
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Sudheesh Katkam
>              Labels: doc-impacting
>             Fix For: Future
>
>         Attachments: index_page.JPG, index_page_mismatch.JPG, screenshots_with_different_states.docx
>
>
> Display drillbit version on web UI. If any of drillbits version doesn't match with current
drillbit, generate warning.
> Screenshots - screenshots_with_different_states.docx.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message