drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4604) Generate warning on Web UI if drillbits version mismatch is detected
Date Fri, 04 Nov 2016 15:51:59 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636764#comment-15636764
] 

ASF GitHub Bot commented on DRILL-4604:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r86570176
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -17,17 +17,56 @@
       <a href="/queries">back</a><br/>
       <div class="page-header">
       </div>
    -  <div class="table-responsive">
    -    <table class="table table-hover">
    -      <tbody>
    -        <#list model as stat>
    -          <tr>
    -            <td style="border:none;"><b>${stat.getName()}</b></td>
    -            <td style="border:none; font-family: Courier;">${stat.getValue()}</td>
    -          </tr>
    -        </#list>
    -      </tbody>
    -    </table>
    +
    +  <#list model.getDrillbits() as drillbit>
    +    <#if !drillbit.isVersionMatch()>
    +      <div id="message" class="alert alert-danger alert-dismissable">
    --- End diff --
    
    This seems to emit a warning about version mismatch for every mismatched Drillbit. Seems
it would be better to list the Drillbits, and look for mismatches. Then, if found, perhaps:
    
    Highlight the mismatched version (in red or whatever) or each Drillbit, then, after the
list of bits, display the message that "One or more drill bits, highlighted above, have versions
different from the cluster version of x.y.z."


> Generate warning on Web UI if drillbits version mismatch is detected
> --------------------------------------------------------------------
>
>                 Key: DRILL-4604
>                 URL: https://issues.apache.org/jira/browse/DRILL-4604
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Sudheesh Katkam
>              Labels: doc-impacting
>             Fix For: Future
>
>         Attachments: index_page.JPG, index_page_mismatch.JPG, screenshots_with_different_states.docx
>
>
> Display drillbit version on web UI. If any of drillbits version doesn't match with current
drillbit, generate warning.
> Screenshots - screenshots_with_different_states.docx.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message