Return-Path: <issues-return-34462-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 7EF94200BA7
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 21 Oct 2016 09:23:00 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 7DA37160AE8; Fri, 21 Oct 2016 07:23:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id C4FEA160AE0
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 21 Oct 2016 09:22:59 +0200 (CEST)
Received: (qmail 16316 invoked by uid 500); 21 Oct 2016 07:22:59 -0000
Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@drill.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@drill.apache.org>
List-Post: <mailto:issues@drill.apache.org>
List-Id: <issues.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list issues@drill.apache.org
Received: (qmail 16303 invoked by uid 99); 21 Oct 2016 07:22:59 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Oct 2016 07:22:59 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id C94DF2C2A69
	for <issues@drill.apache.org>; Fri, 21 Oct 2016 07:22:58 +0000 (UTC)
Date: Fri, 21 Oct 2016 07:22:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12954734.1459367436000.49354.1477034578821@Atlassian.JIRA>
In-Reply-To: <JIRA.12954734.1459367436000@Atlassian.JIRA>
References: <JIRA.12954734.1459367436000@Atlassian.JIRA> <JIRA.12954734.1459367436347@arcas>
Subject: [jira] [Commented] (DRILL-4560) ZKClusterCoordinator does not call
 DrillbitStatusListener.drillbitRegistered for new bits
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 21 Oct 2016 07:23:00 -0000


    [ https://issues.apache.org/jira/browse/DRILL-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594331#comment-15594331 ] 

ASF GitHub Bot commented on DRILL-4560:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/626#discussion_r84428172
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java ---
    @@ -245,33 +242,29 @@ public DrillbitEndpoint apply(ServiceInstance<DrillbitEndpoint> input) {
             StringBuilder builder = new StringBuilder();
             builder.append("Active drillbit set changed.  Now includes ");
             builder.append(newDrillbitSet.size());
    -        builder.append(" total bits.");
    -        if (!newDrillbitSet.isEmpty()) {
    -          builder.append(" New active drillbits: \n");
    -          for (DrillbitEndpoint bit: newDrillbitSet) {
    -            builder.append('\t');
    -            builder.append(bit.getAddress());
    -            builder.append(':');
    -            builder.append(bit.getUserPort());
    -            builder.append(':');
    -            builder.append(bit.getControlPort());
    -            builder.append(':');
    -            builder.append(bit.getDataPort());
    -            builder.append('\n');
    -          }
    +        builder.append(" total bits. New active drillbits:\n");
    --- End diff --
    
    Please change this log from "**New** active drillbits.." to "**Current** active drillbits"


> ZKClusterCoordinator does not call DrillbitStatusListener.drillbitRegistered for new bits
> -----------------------------------------------------------------------------------------
>
>                 Key: DRILL-4560
>                 URL: https://issues.apache.org/jira/browse/DRILL-4560
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components:  Server
>    Affects Versions: 1.6.0
>            Reporter: Paul Rogers
>            Assignee: Sorabh Hamirwasia
>            Priority: Minor
>             Fix For: 1.9.0
>
>
> ZKClusterCoordinator notifies listeners of type DrillbitStatusListener when drillbits disappear from ZooKeeper. The YARN Application Master (AM) also needs to know when bits register themselves with ZK. So, ZKClusterCoordinator should change to detect new Drill-bits, then call DrillbitStatusListener.drillbitRegistered with the new Drill-bits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)