drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4927) Add support for Null Equality Joins
Date Fri, 28 Oct 2016 23:36:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616941#comment-15616941
] 

ASF GitHub Bot commented on DRILL-4927:
---------------------------------------

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/635#discussion_r85625856
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java ---
    @@ -493,4 +496,81 @@ public void withNullEqualAdditionFilter() throws Exception {
             .go();
       }
     
    +  @Test
    +  public void withMixedEqualAndIsNotDistinctHashJoin() throws Exception {
    --- End diff --
    
    Could you add a test with the predicate of type: 
        t1.key = t2.key AND ((t1.data=t2.data) OR (t1.data IS NULL AND t2.data IS NULL))
    where the right side of the AND gets converted to IS NOT DISTINCT FROM.  


> Add support for Null Equality Joins
> -----------------------------------
>
>                 Key: DRILL-4927
>                 URL: https://issues.apache.org/jira/browse/DRILL-4927
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Query Planning & Optimization
>    Affects Versions: 1.8.0
>            Reporter: Roman
>            Assignee: Aman Sinha
>              Labels: doc-impacting
>             Fix For: 1.9.0
>
>
> Join with an equality condition which allows null=null fails. For example, if we use
some of this queries:
> {code:sql}
> select ... FROM t1, t2 WHERE t1.c1 = t2.c2 OR (t1.c1 IS NULL AND t2.c2 IS NULL);
> select ... FROM t1 INNER JOIN  t2 ON  t1.c1 = t2.c2 OR (t1.c1 IS NULL AND t2.c2 IS NULL);
> {code}
> we got "UNSUPPORTED_OPERATION ERROR". We should add support for this option.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message