drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4841) Use user server event loop group for web clients
Date Thu, 06 Oct 2016 22:08:21 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553350#comment-15553350
] 

ASF GitHub Bot commented on DRILL-4841:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/565#discussion_r82269525
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestDistributedFragmentRun.java
---
    @@ -41,7 +41,11 @@
       public void oneBitOneExchangeOneEntryRun() throws Exception{
         RemoteServiceSet serviceSet = RemoteServiceSet.getLocalServiceSet();
     
    -    try(Drillbit bit1 = new Drillbit(CONFIG, serviceSet); DrillClient client = new DrillClient(CONFIG,
serviceSet.getCoordinator());){
    +    try(Drillbit bit1 = new Drillbit(CONFIG, serviceSet);
    --- End diff --
    
    This pattern show up over and over. Should it just be moved into a function rather than
as a duplicated "code injection" in a zillion files?


> Use user server event loop group for web clients
> ------------------------------------------------
>
>                 Key: DRILL-4841
>                 URL: https://issues.apache.org/jira/browse/DRILL-4841
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Client - HTTP
>            Reporter: Sudheesh Katkam
>            Assignee: Sorabh Hamirwasia
>            Priority: Minor
>
> Currently we spawn an event loop group for handling requests from clients. This group
should also be used to handles responses (from server) for web clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message