drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4841) Use user server event loop group for web clients
Date Thu, 06 Oct 2016 22:08:21 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553345#comment-15553345
] 

ASF GitHub Bot commented on DRILL-4841:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/565#discussion_r82269228
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java
---
    @@ -118,8 +118,11 @@ public AnonDrillUserPrincipal(final DrillbitContext drillbitContext)
{
         public DrillClient getDrillClient() throws IOException {
           try {
             // Create a DrillClient
    -        drillClient = new DrillClient(drillbitContext.getConfig(),
    -            drillbitContext.getClusterCoordinator(), drillbitContext.getAllocator());
    +        drillClient = DrillClient.newBuilder()
    --- End diff --
    
    Is the context something we should expose as part of our changes:
    
        DrillbitContext context = ...
        DrillClient client = DrillClient.builder( )
            .fromContext( context )
            .build( );
    
    Doing the above might simplify test code.


> Use user server event loop group for web clients
> ------------------------------------------------
>
>                 Key: DRILL-4841
>                 URL: https://issues.apache.org/jira/browse/DRILL-4841
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Client - HTTP
>            Reporter: Sudheesh Katkam
>            Assignee: Sorabh Hamirwasia
>            Priority: Minor
>
> Currently we spawn an event loop group for handling requests from clients. This group
should also be used to handles responses (from server) for web clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message