drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4604) Generate warning on Web UI if drillbits version mismatch is detected
Date Tue, 25 Oct 2016 19:02:59 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606168#comment-15606168
] 

ASF GitHub Bot commented on DRILL-4604:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r84976814
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -207,6 +210,21 @@ private void javaPropertiesToSystemOptions() {
       }
     
       /**
    +   * If cluster version is the same as default, update option to current drillbit version.
    +   */
    +  private void checkAndUpdateClusterVersionOption(OptionManager optionManager, DrillbitEndpoint
drillbitEndpoint) {
    +    OptionValue versionOption = optionManager.getOption(ExecConstants.CLUSTER_VERSION);
    +    OptionValidator validator = SystemOptionManager.getValidator(ExecConstants.CLUSTER_VERSION);
    +    if (versionOption.equals(validator.getDefault())) {
    +      optionManager.setOption(OptionValue.createOption(
    --- End diff --
    
    Add a comment in code about what happens when multiple drillbits try to set the cluster
version (since `getOption` and `setOption` are separate calls).


> Generate warning on Web UI if drillbits version mismatch is detected
> --------------------------------------------------------------------
>
>                 Key: DRILL-4604
>                 URL: https://issues.apache.org/jira/browse/DRILL-4604
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Sudheesh Katkam
>             Fix For: Future
>
>         Attachments: index_page.JPG, index_page_mismatch.JPG, screenshots_with_different_states.docx
>
>
> Display drillbit version on web UI. If any of drillbits version doesn't match with current
drillbit, generate warning.
> Screenshots - screenshots_with_different_states.docx.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message