drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4560) ZKClusterCoordinator does not call DrillbitStatusListener.drillbitRegistered for new bits
Date Thu, 20 Oct 2016 20:47:59 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592958#comment-15592958
] 

ASF GitHub Bot commented on DRILL-4560:
---------------------------------------

GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/626

    DRILL-4560 - ZKClusterCoordinator fix

    Fix for DRILL-4560 - ZKClusterCoordinator does not call DrillbitStatusListener.drillbitRegistered
for new bits. While this functionality is not needed in Drill itself, it is needed for tools
that monitor Drill (such as Drill on YARN.) Adding this code to Drill avoids the need to clone
the file for other tools.
    
    Also cleaned up logging and comments a bit.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-4560

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #626
    
----
commit 1942c640d5f6a6ae0763534b20f7a757a10c6646
Author: Paul Rogers <progers@maprtech.com>
Date:   2016-10-19T19:15:12Z

    DRILL-4560 - ZKClusterCoordinator fix
    
    Fix for DRILL-4560 - ZKClusterCoordinator does not call
    DrillbitStatusListener.drillbitRegistered for new bits

----


> ZKClusterCoordinator does not call DrillbitStatusListener.drillbitRegistered for new
bits
> -----------------------------------------------------------------------------------------
>
>                 Key: DRILL-4560
>                 URL: https://issues.apache.org/jira/browse/DRILL-4560
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components:  Server
>    Affects Versions: 1.6.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.9.0
>
>
> ZKClusterCoordinator notifies listeners of type DrillbitStatusListener when drillbits
disappear from ZooKeeper. The YARN Application Master (AM) also needs to know when bits register
themselves with ZK. So, ZKClusterCoordinator should change to detect new Drill-bits, then
call DrillbitStatusListener.drillbitRegistered with the new Drill-bits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message