drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4369) Database driver fails to report any major or minor version information
Date Wed, 19 Oct 2016 23:21:58 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590186#comment-15590186
] 

ASF GitHub Bot commented on DRILL-4369:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/622#discussion_r84155576
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserRpcUtils.java
---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.rpc.user;
    +
    +import java.lang.management.ManagementFactory;
    +import java.lang.management.RuntimeMXBean;
    +
    +import org.apache.drill.common.util.DrillVersionInfo;
    +import org.apache.drill.exec.proto.UserProtos.RpcEndpointInfos;
    +
    +import com.google.common.base.Preconditions;
    +
    +/**
    + * Utility class for User RPC
    + *
    + */
    +public final class UserRpcUtils {
    +  private UserRpcUtils() {}
    +
    +  /**
    +   * Returns a {@code RpcEndpointInfos} instance
    +   *
    +   * The instance is populated based on Drill version informations
    +   * from the classpath and runtime information for the application
    +   * name.
    +   *
    +   * @param name the endpoint name.
    +   * @return a {@code RpcEndpointInfos} instance
    +   * @throws NullPointerException if name is null
    +   */
    +  public static RpcEndpointInfos getRpcEndpointInfos(String name) {
    --- End diff --
    
    Infos -> Info


> Database driver fails to report any major or minor version information
> ----------------------------------------------------------------------
>
>                 Key: DRILL-4369
>                 URL: https://issues.apache.org/jira/browse/DRILL-4369
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - JDBC
>    Affects Versions: 1.4.0
>            Reporter: N Campbell
>
> Using Apache 1.4 Drill
> The DatabaseMetadata.getters to obtain the Major and Minor versions of the server or
JDBC driver return 0 instead of 1.4.
> This prevents an application from dynamically adjusting how it interacts based on which
version of Drill a connection is accessing.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message