Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Sun, 11 Sep 2016 11:58:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12979821.1466083658000.541624.1473595100455@Atlassian.JIRA>
In-Reply-To: <JIRA.12979821.1466083658000@Atlassian.JIRA>
References: <JIRA.12979821.1466083658000@Atlassian.JIRA> <JIRA.12979821.1466083658981@arcas>
Subject: [jira] [Commented] (DRILL-4726) Dynamic UDFs support
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 11 Sep 2016 11:58:22 -0000


    [ https://issues.apache.org/jira/browse/DRILL-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481636#comment-15481636 ] 

ASF GitHub Bot commented on DRILL-4726:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r78293364
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/RemoteFunctionRegistry.java ---
    @@ -0,0 +1,185 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.expr.fn;
    +
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +import org.apache.commons.io.FilenameUtils;
    +import org.apache.drill.common.config.DrillConfig;
    +import org.apache.drill.common.exceptions.DrillRuntimeException;
    +import org.apache.drill.exec.ExecConstants;
    +import org.apache.drill.exec.coord.ClusterCoordinator;
    +import org.apache.drill.exec.coord.store.TransientStore;
    +import org.apache.drill.exec.coord.store.TransientStoreConfig;
    +import org.apache.drill.exec.coord.store.TransientStoreListener;
    +import org.apache.drill.exec.exception.StoreException;
    +import org.apache.drill.exec.exception.VersionMismatchException;
    +import org.apache.drill.exec.proto.SchemaUserBitShared;
    +import org.apache.drill.exec.proto.UserBitShared.Registry;
    +import org.apache.drill.exec.store.sys.PersistentStore;
    +import org.apache.drill.exec.store.sys.PersistentStoreConfig;
    +import org.apache.drill.exec.store.sys.PersistentStoreProvider;
    +import org.apache.drill.exec.store.sys.store.DataChangeVersion;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.FileSystem;
    +import org.apache.hadoop.fs.Path;
    +
    +import java.io.IOException;
    +
    +import static com.fasterxml.jackson.databind.SerializationFeature.INDENT_OUTPUT;
    +
    +/** Is responsible for remote function registry management.
    + *  Creates all remote registry areas at startup, during init establishes connections with stores.
    + *  Provides tools to update remote registry and unregister functions, access remote registry areas.
    + */
    +public class RemoteFunctionRegistry implements AutoCloseable {
    --- End diff --
    
    This class has two functions:
    1. prepare environment for remote function registry which is done at start up (we have only one instance of this class per drillbit).
    2. delegate actions to Zookeeper which handles synchronization by itself.
    So we don't any synchronization in this class. 


> Dynamic UDFs support
> --------------------
>
>                 Key: DRILL-4726
>                 URL: https://issues.apache.org/jira/browse/DRILL-4726
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> Allow register UDFs without  restart of Drillbits.
> Design is described in document below:
> https://docs.google.com/document/d/1FfyJtWae5TLuyheHCfldYUpCdeIezR2RlNsrOTYyAB4/edit?usp=sharing 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)