drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4726) Dynamic UDFs support
Date Mon, 26 Sep 2016 21:53:22 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524286#comment-15524286
] 

ASF GitHub Bot commented on DRILL-4726:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r80542988
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
    @@ -179,14 +190,15 @@ public DrillFuncHolder findExactMatchingDrillFunction(String name,
List<MajorTyp
       }
     
       private DrillFuncHolder findExactMatchingDrillFunction(String name, List<MajorType>
argTypes, MajorType returnType, boolean retry) {
    -    for (DrillFuncHolder h : drillFuncRegistry.getMethods(name)) {
    +    AtomicLong version = new AtomicLong();
    --- End diff --
    
    Not entirely clear how the version works. We create it here and intialze it to 0. Then
in loadRemoteFunctions( ), we compare the local version (always 0) to the registry version
(which will be zero only until, presumably, the first load.) Are we missing an initialization
here to the current registry version? Else, please explain how this works.


> Dynamic UDFs support
> --------------------
>
>                 Key: DRILL-4726
>                 URL: https://issues.apache.org/jira/browse/DRILL-4726
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> Allow register UDFs without  restart of Drillbits.
> Design is described in document below:
> https://docs.google.com/document/d/1FfyJtWae5TLuyheHCfldYUpCdeIezR2RlNsrOTYyAB4/edit?usp=sharing




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message