drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4726) Dynamic UDFs support
Date Wed, 07 Sep 2016 17:38:20 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471277#comment-15471277

ASF GitHub Bot commented on DRILL-4726:

Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/RemoteFunctionRegistry.java
    @@ -0,0 +1,185 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.expr.fn;
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +import org.apache.commons.io.FilenameUtils;
    +import org.apache.drill.common.config.DrillConfig;
    +import org.apache.drill.common.exceptions.DrillRuntimeException;
    +import org.apache.drill.exec.ExecConstants;
    +import org.apache.drill.exec.coord.ClusterCoordinator;
    +import org.apache.drill.exec.coord.store.TransientStore;
    +import org.apache.drill.exec.coord.store.TransientStoreConfig;
    +import org.apache.drill.exec.coord.store.TransientStoreListener;
    +import org.apache.drill.exec.exception.StoreException;
    +import org.apache.drill.exec.exception.VersionMismatchException;
    +import org.apache.drill.exec.proto.SchemaUserBitShared;
    +import org.apache.drill.exec.proto.UserBitShared.Registry;
    +import org.apache.drill.exec.store.sys.PersistentStore;
    +import org.apache.drill.exec.store.sys.PersistentStoreConfig;
    +import org.apache.drill.exec.store.sys.PersistentStoreProvider;
    +import org.apache.drill.exec.store.sys.store.DataChangeVersion;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.FileSystem;
    +import org.apache.hadoop.fs.Path;
    +import java.io.IOException;
    +import static com.fasterxml.jackson.databind.SerializationFeature.INDENT_OUTPUT;
    +/** Is responsible for remote function registry management.
    + *  Creates all remote registry areas at startup, during init establishes connections
with stores.
    + *  Provides tools to update remote registry and unregister functions, access remote
registry areas.
    + */
    +public class RemoteFunctionRegistry implements AutoCloseable {
    --- End diff --
    This seems to be the class where the DFS and ZK aspects of UDF registration come together.
But, it is not clear how this is synchronized within a single process or across processes.
There are two parts to this comment.
    First, it would be great to explain the synchronization model in the class comment. Walk
through the life cycle and the actions. Explain how they are synchronized.
    Second, if there are holes (still trying to figure that out), then those need to be addressed.

> Dynamic UDFs support
> --------------------
>                 Key: DRILL-4726
>                 URL: https://issues.apache.org/jira/browse/DRILL-4726
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
> Allow register UDFs without  restart of Drillbits.
> Design is described in document below:
> https://docs.google.com/document/d/1FfyJtWae5TLuyheHCfldYUpCdeIezR2RlNsrOTYyAB4/edit?usp=sharing

This message was sent by Atlassian JIRA

View raw message