drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4726) Dynamic UDFs support
Date Tue, 06 Sep 2016 18:28:20 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468137#comment-15468137
] 

ASF GitHub Bot commented on DRILL-4726:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77691775
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
    @@ -39,15 +46,20 @@
     
     import com.google.common.collect.ArrayListMultimap;
     import org.apache.drill.exec.planner.sql.DrillSqlOperatorWithoutInference;
    +import org.apache.drill.exec.proto.UserBitShared.Func;
     
     /**
      * Registry of Drill functions.
      */
     public class DrillFunctionRegistry {
    +
    +  public static final String BUILT_IN = "built-in";
    +
       private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(DrillFunctionRegistry.class);
     
    -  // key: function name (lowercase) value: list of functions with that name
    -  private final ArrayListMultimap<String, DrillFuncHolder> registeredFunctions
= ArrayListMultimap.create();
    +  // function registry holder
    --- End diff --
    
    Did cursory review. Needs thorough review from someone familiar with this code.


> Dynamic UDFs support
> --------------------
>
>                 Key: DRILL-4726
>                 URL: https://issues.apache.org/jira/browse/DRILL-4726
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> Allow register UDFs without  restart of Drillbits.
> Design is described in document below:
> https://docs.google.com/document/d/1FfyJtWae5TLuyheHCfldYUpCdeIezR2RlNsrOTYyAB4/edit?usp=sharing




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message