drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4726) Dynamic UDFs support
Date Tue, 06 Sep 2016 18:26:20 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468127#comment-15468127
] 

ASF GitHub Bot commented on DRILL-4726:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77691307
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
    @@ -64,62 +76,134 @@
           .put("CONVERT_FROM", Pair.of(2, 2))
           .put("FLATTEN", Pair.of(1, 1)).build();
     
    +  /** Registers all functions present in Drill classpath on start-up. All functions will
be marked as built-in.*/
       public DrillFunctionRegistry(ScanResult classpathScan) {
    +    validate(BUILT_IN, classpathScan);
    +    register(BUILT_IN, classpathScan, this.getClass().getClassLoader());
    +    if (logger.isTraceEnabled()) {
    +      StringBuilder allFunctions = new StringBuilder();
    +      for (DrillFuncHolder method: registryHolder.getAllFunctionsWithHolders().values())
{
    +        allFunctions.append(method.toString()).append("\n");
    +      }
    +      logger.trace("Registered functions: [\n{}]", allFunctions);
    +    }
    +  }
    +
    +  /**
    +   * Validates all functions, present in jars.
    +   * Will throw {@link FunctionValidationException} if:
    --- End diff --
    
    This is a JavaDoc comment, so HTML. To display correctly, use:
    <ol>
    <li>Jar with same name...</li>
    <li>...</li>
    </ol>


> Dynamic UDFs support
> --------------------
>
>                 Key: DRILL-4726
>                 URL: https://issues.apache.org/jira/browse/DRILL-4726
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> Allow register UDFs without  restart of Drillbits.
> Design is described in document below:
> https://docs.google.com/document/d/1FfyJtWae5TLuyheHCfldYUpCdeIezR2RlNsrOTYyAB4/edit?usp=sharing




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message