Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D25DA200B50 for ; Fri, 15 Jul 2016 00:37:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D0D12160A85; Thu, 14 Jul 2016 22:37:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4BFDD160A63 for ; Fri, 15 Jul 2016 00:37:21 +0200 (CEST) Received: (qmail 92746 invoked by uid 500); 14 Jul 2016 22:37:20 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 92734 invoked by uid 99); 14 Jul 2016 22:37:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jul 2016 22:37:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6A1192C02A1 for ; Thu, 14 Jul 2016 22:37:20 +0000 (UTC) Date: Thu, 14 Jul 2016 22:37:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-4664) ScanBatch.isNewSchema() returns wrong result for map datatype MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 14 Jul 2016 22:37:22 -0000 [ https://issues.apache.org/jira/browse/DRILL-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378518#comment-15378518 ] ASF GitHub Bot commented on DRILL-4664: --------------------------------------- Github user hnfgns commented on the issue: https://github.com/apache/drill/pull/516 looks good to me +1 @parthchandra can we run regression and merge? > ScanBatch.isNewSchema() returns wrong result for map datatype > ------------------------------------------------------------- > > Key: DRILL-4664 > URL: https://issues.apache.org/jira/browse/DRILL-4664 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Flow > Affects Versions: 1.6.0 > Reporter: Vitalii Diravka > Priority: Minor > > isNewSchema() method checks if top-level schema or any of the deeper map schemas has changed. The last one doesn't work properly with count function. > "deeperSchemaChanged" equals true even when two map strings have the same children fields. > Discovered while trying to fix [DRILL-2385|DRILL-2385]. > Dataset test.json for reproducing (MAP datatype object): > {code}{"oooi":{"oa":{"oab":{"oabc":1}}}}{code} > Example of query: > {code}select count(t.oooi) from dfs.tmp.`test.json` t{code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)