drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4682) Allow full schema identifier in SELECT clause
Date Wed, 27 Jul 2016 20:44:20 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396335#comment-15396335

ASF GitHub Bot commented on DRILL-4682:

Github user vdiravka commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
    @@ -115,6 +119,18 @@ public SqlNode visitChild(
               enableComplex = true;
    +      if (expr.getKind() == SqlKind.SELECT) {
    +        if (((SqlSelect) expr).getFrom() instanceof DrillCompoundIdentifier) {
    +          fullSchemasSet.add((DrillCompoundIdentifier) ((SqlSelect) expr).getFrom());
    +        } else if (((SqlSelect) expr).getFrom() instanceof SqlJoin) {
    --- End diff --
    Done in the new commit.

> Allow full schema identifier in SELECT clause
> ---------------------------------------------
>                 Key: DRILL-4682
>                 URL: https://issues.apache.org/jira/browse/DRILL-4682
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: SQL Parser
>            Reporter: Andries Engelbrecht
>            Assignee: Vitalii Diravka
> Currently Drill requires aliases to identify columns in the SELECT clause when working
with multiple tables/workspaces.
> Many BI/Analytical and other tools by default will use the full schema identifier in
the select clause when generating SQL statements for execution for generic JDBC or ODBC sources.
Not supporting this feature causes issues and a slower adoption of utilizing Drill as an execution
engine within the larger Analytical SQL community.
> Propose to support 
> SELECT <storage_plugin>.<workspace>.<table>.<column> FROM <storage_plugin>.<workspace>.<table>
> Also see DRILL-3510 for double quote support as per ANSI_QUOTES
> SELECT "<storage_plugin>"."<workspace>"."<table>"."<column>"
FROM "<storage_plugin>"."<workspace>"."<table>"
> Which is very common generic SQL being generated by most tools when dealing with a generic
SQL data source.

This message was sent by Atlassian JIRA

View raw message