drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4682) Allow full schema identifier in SELECT clause
Date Fri, 22 Jul 2016 16:06:20 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389748#comment-15389748

ASF GitHub Bot commented on DRILL-4682:

Github user jinfengni commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillCompoundIdentifier.java
    @@ -69,31 +70,38 @@ public void addIndex(int index, SqlParserPos pos){
    -  public SqlNode getAsSqlNode(){
    -    if(ids.size() == 1){
    +  public SqlNode getAsSqlNode(Set<DrillCompoundIdentifier> fullSchemasSet) {
    --- End diff --
    Can you add comment why you have to pass in the set of fullSchema? Without it, why will
the previous code treat "cp" in "cp.`employee.json`" as a table name rather than schema name?

> Allow full schema identifier in SELECT clause
> ---------------------------------------------
>                 Key: DRILL-4682
>                 URL: https://issues.apache.org/jira/browse/DRILL-4682
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: SQL Parser
>            Reporter: Andries Engelbrecht
> Currently Drill requires aliases to identify columns in the SELECT clause when working
with multiple tables/workspaces.
> Many BI/Analytical and other tools by default will use the full schema identifier in
the select clause when generating SQL statements for execution for generic JDBC or ODBC sources.
Not supporting this feature causes issues and a slower adoption of utilizing Drill as an execution
engine within the larger Analytical SQL community.
> Propose to support 
> SELECT <storage_plugin>.<workspace>.<table>.<column> FROM <storage_plugin>.<workspace>.<table>
> Also see DRILL-3510 for double quote support as per ANSI_QUOTES
> SELECT "<storage_plugin>"."<workspace>"."<table>"."<column>"
FROM "<storage_plugin>"."<workspace>"."<table>"
> Which is very common generic SQL being generated by most tools when dealing with a generic
SQL data source.

This message was sent by Atlassian JIRA

View raw message