drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4673) Implement "DROP TABLE IF EXISTS" for drill to prevent FAILED status on command return
Date Thu, 07 Jul 2016 21:32:11 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366819#comment-15366819
] 

ASF GitHub Bot commented on DRILL-4673:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/541#discussion_r69991328
  
    --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
    @@ -199,15 +199,17 @@ SqlNode SqlCreateOrReplaceView() :
      * Parses a drop view statement.
      * DROP VIEW view_name;
      */
    -SqlNode SqlDropView() :
    +SqlNode SqlDropViewIfExists() :
     {
         SqlParserPos pos;
    +    boolean viewExistenceCheck = false;
     }
     {
         <DROP> { pos = getPos(); }
         <VIEW>
    +    [ <IF> <EXISTS> { viewExistenceCheck = true; } ]
         {
    -        return new SqlDropView(pos, CompoundIdentifier());
    +        return new SqlDropView(pos, CompoundIdentifier(), viewExistenceCheck);
    --- End diff --
    
    Should this be `return new SqlDropViewIfExists(..);`?


> Implement "DROP TABLE IF EXISTS" for drill to prevent FAILED status on command return
> -------------------------------------------------------------------------------------
>
>                 Key: DRILL-4673
>                 URL: https://issues.apache.org/jira/browse/DRILL-4673
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Functions - Drill
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Minor
>              Labels: drill
>
> Implement "DROP TABLE IF EXISTS" for drill to prevent FAILED status on command "DROP
TABLE" return if table doesn't exist.
> The same for "DROP VIEW IF EXISTS"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message