Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Wed, 25 May 2016 16:12:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12971796.1463839161000.289561.1464192732887@Atlassian.JIRA>
In-Reply-To: <JIRA.12971796.1463839161000@Atlassian.JIRA>
References: <JIRA.12971796.1463839161000@Atlassian.JIRA> <JIRA.12971796.1463839161022@arcas>
Subject: [jira] [Commented] (DRILL-4690) Header in RestApi CORS support
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 25 May 2016 16:12:20 -0000


    [ https://issues.apache.org/jira/browse/DRILL-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300302#comment-15300302 ] 

ASF GitHub Bot commented on DRILL-4690:
---------------------------------------

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/507#discussion_r64602614
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java ---
    @@ -159,6 +163,14 @@ public void start() throws Exception {
           servletContextHandler.setSessionHandler(createSessionHandler(servletContextHandler.getSecurityHandler()));
         }
     
    +    if (config.getBoolean(ExecConstants.HTTP_ENABLE_CORS)) {
    +      FilterHolder cors = servletContextHandler.addFilter(CrossOriginFilter.class, "/*", EnumSet.of(DispatcherType.REQUEST));
    +      cors.setInitParameter(CrossOriginFilter.ALLOWED_ORIGINS_PARAM, "*");
    +      cors.setInitParameter(CrossOriginFilter.ACCESS_CONTROL_ALLOW_ORIGIN_HEADER, "*");
    --- End diff --
    
    if it doesn't end with _PARAM, it probably means it's not a param but a constant used for something else (likely to set a HTTP header in the response). It's probably harmless, but better be removed.


> Header in RestApi CORS support 
> -------------------------------
>
>                 Key: DRILL-4690
>                 URL: https://issues.apache.org/jira/browse/DRILL-4690
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Wojciech Nowak
>            Priority: Minor
>
> Damien Cantreras raised question on mailing list, related to Drill RestAPI support for Header "Access-Control-Allow-Origin: *"
> to allow it being used from a HTML5 application.
> Place where Header should be added https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)