Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Tue, 17 May 2016 18:22:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12969835.1463324633000.213486.1463509332873@Atlassian.JIRA>
In-Reply-To: <JIRA.12969835.1463324633000@Atlassian.JIRA>
References: <JIRA.12969835.1463324633000@Atlassian.JIRA> <JIRA.12969835.1463324633428@arcas>
Subject: [jira] [Commented] (DRILL-4676) Foreman.moveToState can block
 forever if called by the foreman thread while the query is still being
 setup
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 17 May 2016 18:22:14 -0000


    [ https://issues.apache.org/jira/browse/DRILL-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287178#comment-15287178 ] 

ASF GitHub Bot commented on DRILL-4676:
---------------------------------------

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/503#discussion_r63576357
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
    @@ -1191,7 +1195,7 @@ public void failed(final RpcException ex) {
           } else {
             // since this won't be waited on, we can wait to deliver this event once the Foreman is ready
             logger.debug("Failure while sending fragment.  Stopping query.", ex);
    -        stateListener.moveToState(QueryState.FAILED, ex);
    --- End diff --
    
    what do you mean by "deferring this" ?


> Foreman.moveToState can block forever if called by the foreman thread while the query is still being setup
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4676
>                 URL: https://issues.apache.org/jira/browse/DRILL-4676
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 1.6.0
>            Reporter: Deneche A. Hakim
>            Assignee: Sudheesh Katkam
>             Fix For: 1.7.0
>
>
> When the query is being setup, foreman has a special CountDownLatch that blocks rpc threads from delivering external events, this latch is unblocked at the end of the query setup.
> In some cases though, when the foreman is submitting remote fragments, a failure in RpcBus.send() causes an exception to be thrown that is reported to 
> Foreman.FragmentSubmitListener and blocks in the CountDownLatch. This causes the foreman thread to block forever, and can rpc threads to be blocked too.
> This seems to happen more frequently at a high concurrency load, and also can prevent clients from connecting to the Drillbits.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)