drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4690) Header in RestApi CORS support
Date Wed, 25 May 2016 18:49:12 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300636#comment-15300636
] 

ASF GitHub Bot commented on DRILL-4690:
---------------------------------------

Github user PythonicNinja commented on a diff in the pull request:

    https://github.com/apache/drill/pull/507#discussion_r64630482
  
    --- Diff: exec/jdbc-all/pom.xml ---
    @@ -441,7 +441,7 @@
                       This is likely due to you adding new dependencies to a java-exec and
not updating the excludes in this module. This is important as it minimizes the size of the
dependency of Drill application users.
                       
                       </message>
    -                  <maxsize>20000000</maxsize>
    +                  <maxsize>21000000</maxsize>
    --- End diff --
    
    Once I have added that:
    <groupId>org.eclipse.jetty</groupId>
    <artifactId>jetty-servlets</artifactId>
    <version>9.3.9.v20160517</version>
    
    size grew, I will change version to match with jetty version.
    
    Maybe we should add exclusions for that dependency. 
    @hnfgns Can you suggest what to add in exclusions list?


> Header in RestApi CORS support 
> -------------------------------
>
>                 Key: DRILL-4690
>                 URL: https://issues.apache.org/jira/browse/DRILL-4690
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Wojciech Nowak
>            Priority: Minor
>
> Damien Cantreras raised question on mailing list, related to Drill RestAPI support for
Header "Access-Control-Allow-Origin: *"
> to allow it being used from a HTML5 application.
> Place where Header should be added https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message