drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4690) Header in RestApi CORS support
Date Wed, 25 May 2016 18:42:12 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300624#comment-15300624
] 

ASF GitHub Bot commented on DRILL-4690:
---------------------------------------

Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/507#discussion_r64629211
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -110,6 +110,7 @@ drill.exec: {
       http: {
         enabled: true,
         ssl_enabled: false,
    +    cors_enabled: true,
    --- End diff --
    
    perhaps we should consider extending cors configuration with 
    ```
    http: {
      cors: {
        enabled: true,
        allowedOrigins: ['*.mydomain.com', '*.someother.net'], --> configures Access-Control-Allow-Origin
        allowedMethods: ['option', 'get', 'post', 'some-other'], --> configures  Access-Control-Allow-Methods
        allowedHeaders: ['some-allowed-header'], --> configures Access-Control-Expose-Headers

        credentials: true | false -- >  configures Access-Control-Allow-Credentials
      }
    }
    ```
    I am probably missing few in the list but I find these options essential.


> Header in RestApi CORS support 
> -------------------------------
>
>                 Key: DRILL-4690
>                 URL: https://issues.apache.org/jira/browse/DRILL-4690
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Wojciech Nowak
>            Priority: Minor
>
> Damien Cantreras raised question on mailing list, related to Drill RestAPI support for
Header "Access-Control-Allow-Origin: *"
> to allow it being used from a HTML5 application.
> Place where Header should be added https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message