drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4690) Header in RestApi CORS support
Date Wed, 25 May 2016 16:12:12 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300302#comment-15300302
] 

ASF GitHub Bot commented on DRILL-4690:
---------------------------------------

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/507#discussion_r64602614
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
    @@ -159,6 +163,14 @@ public void start() throws Exception {
           servletContextHandler.setSessionHandler(createSessionHandler(servletContextHandler.getSecurityHandler()));
         }
     
    +    if (config.getBoolean(ExecConstants.HTTP_ENABLE_CORS)) {
    +      FilterHolder cors = servletContextHandler.addFilter(CrossOriginFilter.class, "/*",
EnumSet.of(DispatcherType.REQUEST));
    +      cors.setInitParameter(CrossOriginFilter.ALLOWED_ORIGINS_PARAM, "*");
    +      cors.setInitParameter(CrossOriginFilter.ACCESS_CONTROL_ALLOW_ORIGIN_HEADER, "*");
    --- End diff --
    
    if it doesn't end with _PARAM, it probably means it's not a param but a constant used
for something else (likely to set a HTTP header in the response). It's probably harmless,
but better be removed.


> Header in RestApi CORS support 
> -------------------------------
>
>                 Key: DRILL-4690
>                 URL: https://issues.apache.org/jira/browse/DRILL-4690
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Wojciech Nowak
>            Priority: Minor
>
> Damien Cantreras raised question on mailing list, related to Drill RestAPI support for
Header "Access-Control-Allow-Origin: *"
> to allow it being used from a HTML5 application.
> Place where Header should be added https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message